chesstool Issue Tracker Rss Feed

Commented Issue: Wrong TimeSpan usage [8715]

etobi — Thu, 22 Sep 2011 17:55:20 GMT

In a lot of places, you di timeSpan.Milliseconds where timeSpan.TotalMilliseconds should be used. For e.g. TimeSpan.FormMinutes(1), Milliseconds is 0, but TotalMilliseconds is 60000.
Please see the attached patch.
Comments: ** Comment from web user: etobi **

It's not just a SVN thing *.patch/*.diff files are used for a looooong time to represent changes in plain text files. I think TFS can create patches with `tf diff` as well - but, I haven't touched TFS for a long time in favour to Git.

Anyways: The changes at least fix an issue with some false-positive deadlock-warnings when e.g. Monitor.Wait(@lock, TimeSpan.FromHours(1)) is used (where .Milliseconds would return 0).
But after fixing this I ran into another issue - seems Chess doesn't track all threads resulting in one thread using the original Monitor.Wait() method and other threads to use the modified version of Monitor.PulseAll(), causing the waiting thread to never wake up.

Commented Issue: Wrong TimeSpan usage [8715]

mormayo — Thu, 22 Sep 2011 17:11:10 GMT

Ah, some searching on Google tells me that patch looks like an SVN thing. Please forgive me as I do not have SVN installed (I use TFS) and hadn't heard of it before.

I've pasted the contents below:
Index: Framework4Wrappers/Task.cs
===================================================================
--- Framework4Wrappers/Task.cs (revision 62424)
+++ Framework4Wrappers/Task.cs (working copy)
@@ -219,7 +219,7 @@
}
public static bool Wait(Original::Task self, TimeSpan timeout)
{
- return WaitRaw(self, timeout.Milliseconds, CancellationToken.None);
+ return WaitRaw(self, (int) timeout.TotalMilliseconds, CancellationToken.None);
}
public static bool Wait(Original::Task self, int millisecondsTimeout, CancellationToken cancellationToken)
{
@@ -349,7 +349,7 @@
}
public static bool WaitAll(Original::Task[] tasks, TimeSpan timeout)
{
- return WaitAllRaw(tasks, timeout.Milliseconds, CancellationToken.None);
+ return WaitAllRaw(tasks, (int) timeout.TotalMilliseconds, CancellationToken.None);
}
public static bool WaitAll(Original::Task[] tasks, int millisecondsTimeout, CancellationToken cancellationToken)
{
@@ -369,7 +369,7 @@
}
public static int WaitAny(Original::Task[] tasks, TimeSpan timeout)
{
- return WaitAnyRaw(tasks, timeout.Milliseconds, CancellationToken.None);
+ return WaitAnyRaw(tasks, (int) timeout.TotalMilliseconds, CancellationToken.None);
}
public static int WaitAny(Original::Task[] tasks, int millisecondsTimeout, CancellationToken cancellationToken)
{
Index: Microsoft.ManagedChess.Framework35Wrappers/readerwriterlockslim.cs
===================================================================
--- Microsoft.ManagedChess.Framework35Wrappers/readerwriterlockslim.cs (revision 62424)
+++ Microsoft.ManagedChess.Framework35Wrappers/readerwriterlockslim.cs (working copy)
@@ -72,7 +72,7 @@

public static bool TryEnterReadLock(Original::ReaderWriterLockSlim @lock, TimeSpan timeSpan)
{
- return TryEnterRaw(@lock, timeSpan.Milliseconds, "TryEnterReadLock", MODE.READ);
+ return TryEnterRaw(@lock, (int) timeSpan.TotalMilliseconds, "TryEnterReadLock", MODE.READ);
}

public static bool TryEnterWriteLock(Original::ReaderWriterLockSlim @lock, int millisecondsTimeout)
@@ -82,7 +82,7 @@

public static bool TryEnterWriteLock(Original::ReaderWriterLockSlim @lock, TimeSpan timeSpan)
{
- return TryEnterRaw(@lock, timeSpan.Milliseconds, "TryEnterWriteLock", MODE.WRITE);
+ return TryEnterRaw(@lock, (int) timeSpan.TotalMilliseconds, "TryEnterWriteLock", MODE.WRITE);
}

public static bool TryEnterUpgradeableReadLock(Original::ReaderWriterLockSlim @lock, int millisecondsTimeout)
@@ -92,7 +92,7 @@

public static bool TryEnterUpgradeableReadLock(Original::ReaderWriterLockSlim @lock, TimeSpan ts)
{
- return TryEnterRaw(@lock, ts.Milliseconds, "TryEnterUpgradeableReadLock", MODE.UPGRADEABLE_READ);
+ return TryEnterRaw(@lock, (int) ts.TotalMilliseconds, "TryEnterUpgradeableReadLock", MODE.UPGRADEABLE_READ);
}

public static bool TryEnterRaw(Original::ReaderWriterLockSlim @lock, int millisecondsTimeout, string name, MODE mode)
Index: ThreadingWrappers/Monitor.cs
===================================================================
--- ThreadingWrappers/Monitor.cs (revision 62424)
+++ ThreadingWrappers/Monitor.cs (working copy)
@@ -91,15 +91,15 @@
// an exclusive lock on the specified object.
public static bool TryEnter(object @lock, TimeSpan timeOut)
{
- MSyncVarOp mop = (timeOut.Milliseconds == Timeout.Infinite) ? MSyncVarOp.LOCK_ACQUIRE : MSyncVarOp.LOCK_TRYACQUIRE;
- return TryEnterRaw(@lock, timeOut.Milliseconds, mop, "Monitor.TryEnter");
+ MSyncVarOp mop = (timeOut.TotalMilliseconds == Timeout.Infinite) ? MSyncVarOp.LOCK_ACQUIRE : MSyncVarOp.LOCK_TRYACQUIRE;
+ return TryEnterRaw(@lock, (int) timeOut.TotalMilliseconds, mop, "Monitor.TryEnter");
}

public static void TryEnter(object obj, TimeSpan millisecondsTimeout, ref bool tookLock)
{
global::System.Diagnostics.Debug.Assert(!tookLock);
- MSyncVarOp mop = (millisecondsTimeout.Milliseconds == Timeout.Infinite) ? MSyncVarOp.LOCK_ACQUIRE : MSyncVarOp.LOCK_TRYACQUIRE;
- tookLock = TryEnterRaw(obj, millisecondsTimeout.Milliseconds, mop, "Monitor.TryEnter");
+ MSyncVarOp mop = (millisecondsTimeout.TotalMilliseconds == Timeout.Infinite) ? MSyncVarOp.LOCK_ACQUIRE : MSyncVarOp.LOCK_TRYACQUIRE;
+ tookLock = TryEnterRaw(obj, (int) millisecondsTimeout.TotalMilliseconds, mop, "Monitor.TryEnter");
}

// Monitor.TryEnter (Object) Attempts to acquire an exclusive lock on the specified object.
@@ -281,7 +281,7 @@
// - If the specified time-out interval elapses, the thread enters the ready queue.
public static bool Wait(object @lock, TimeSpan timeOut)
{
- return WaitRaw(@lock, timeOut.Milliseconds, false);
+ return WaitRaw(@lock, (int) timeOut.TotalMilliseconds, false);
}

// Monitor.Wait (Object, Int32, Boolean)
@@ -301,7 +301,7 @@
// - reacquires the domain afterward.
public static bool Wait(object @lock, TimeSpan timeOut, bool domain)
{
- return WaitRaw(@lock, timeOut.Milliseconds, domain);
+ return WaitRaw(@lock, (int) timeOut.TotalMilliseconds, domain);
}

private static bool WaitRaw(object @lock, int timeOut, bool domain)
Index: ThreadingWrappers/Mutex.cs
===================================================================
--- ThreadingWrappers/Mutex.cs (revision 62424)
+++ ThreadingWrappers/Mutex.cs (working copy)
@@ -71,7 +71,7 @@

public static bool WaitOne(Original::Mutex mutex, TimeSpan timeOut, bool exitContext)
{
- return WaitOneRaw(mutex, timeOut.Milliseconds, exitContext);
+ return WaitOneRaw(mutex, (int) timeOut.TotalMilliseconds, exitContext);
}

private static bool WaitOneRaw(Original::Mutex mutex, int timeOut, bool domain)
Index: ThreadingWrappers/Thread.cs
===================================================================
--- ThreadingWrappers/Thread.cs (revision 62424)
+++ ThreadingWrappers/Thread.cs (working copy)
@@ -66,7 +66,7 @@
Helper.SimpleWrap<bool>(
delegate(ClrSyncManager manager)
{
- if (timeout.Milliseconds < Timeout.Infinite)
+ if (timeout.TotalMilliseconds < Timeout.Infinite)
throw new ArgumentOutOfRangeException();
// sleep with TimeSpan cannot be infinite
manager.TaskYield();
@@ -137,7 +137,7 @@
public static bool Join(Original::Thread thread, TimeSpan timespan)
{
return Helper.SimpleWrap<bool>(
- delegate(ClrSyncManager m) { return JoinRaw(thread, m, timespan.Milliseconds); },
+ delegate(ClrSyncManager m) { return JoinRaw(thread, m, (int) timespan.TotalMilliseconds); },
delegate() { return thread.Join(timespan);}
);
}
Index: ThreadingWrappers/threadpool.cs
===================================================================
--- ThreadingWrappers/threadpool.cs (revision 62424)
+++ ThreadingWrappers/threadpool.cs (working copy)
@@ -219,7 +219,7 @@
TimeSpan timeOut,
bool executeOnlyOnce)
{
- return RegisterWaitForSingleObjectHelper(waitObject, callBack, state, timeOut.Milliseconds, executeOnlyOnce, true);
+ return RegisterWaitForSingleObjectHelper(waitObject, callBack, state, (long) timeOut.TotalMilliseconds, executeOnlyOnce, true);
}

public static Original.RegisteredWaitHandle RegisterWaitForSingleObject(
@@ -259,7 +259,7 @@
TimeSpan ts,
bool executeOnlyOnce)
{
- return RegisterWaitForSingleObjectHelper(waitObject, callBack, state, ts.Milliseconds, executeOnlyOnce, false);
+ return RegisterWaitForSingleObjectHelper(waitObject, callBack, state, (long) ts.TotalMilliseconds, executeOnlyOnce, false);
}

public static Original.RegisteredWaitHandle UnsafeRegisterWaitForSingleObject(
Index: ThreadingWrappers/Timer.cs
===================================================================
--- ThreadingWrappers/Timer.cs (revision 62424)
+++ ThreadingWrappers/Timer.cs (working copy)
@@ -232,9 +232,9 @@

public static Original::Timer ___ctor_newobj(Original::TimerCallback tc, object state, TimeSpan dueTime, TimeSpan period)
{
- if (dueTime.Milliseconds< 0 && dueTime.Milliseconds != Timeout.Infinite)
+ if (dueTime.TotalMilliseconds< 0 && dueTime.TotalMilliseconds != Timeout.Infinite)
throw new ArgumentOutOfRangeException();
- if (period.Milliseconds < 0 && period.Milliseconds != Timeout.Infinite)
+ if (period.TotalMilliseconds < 0 && period.TotalMilliseconds != Timeout.Infinite)
throw new ArgumentOutOfRangeException();
return Helper.SimpleWrap<Original::Timer>(
delegate(ClrSyncManager manager) { return TimerHelpers.CreateTimer(manager, tc, state, dueTime, period); },
@@ -328,7 +328,7 @@

public static bool Change(Original::Timer t, TimeSpan dueTime, TimeSpan period)
{
- return Change(t, (long)dueTime.Milliseconds, (long)period.Milliseconds);
+ return Change(t, (long)dueTime.TotalMilliseconds, (long)period.TotalMilliseconds);
}

public static bool Change(Original::Timer t, uint dueTime, uint period)
Index: ThreadingWrappers/WaitHandle.cs
===================================================================
--- ThreadingWrappers/WaitHandle.cs (revision 62424)
+++ ThreadingWrappers/WaitHandle.cs (working copy)
@@ -137,7 +137,7 @@
{
if (h == null)
throw new NullReferenceException();
- return WaitOne(h, timeout.Milliseconds, exitContext);
+ return WaitOne(h, (int) timeout.TotalMilliseconds, exitContext);
}

public static int WaitAny(Original::WaitHandle[] waitHandles)
@@ -162,7 +162,7 @@

public static int WaitAny(Original::WaitHandle[] waitHandles, TimeSpan timeout, bool exitContext)
{
- return WaitAny(waitHandles, timeout.Milliseconds, exitContext);
+ return WaitAny(waitHandles, (int) timeout.TotalMilliseconds, exitContext);
}

public static bool WaitAll(Original::WaitHandle[] waitHandles)
@@ -187,7 +187,7 @@

public static bool WaitAll(Original::WaitHandle[] waitHandles, TimeSpan timeout, bool exitContext)
{
- return WaitAll(waitHandles, timeout.Milliseconds, exitContext);
+ return WaitAll(waitHandles, (int) timeout.TotalMilliseconds, exitContext);
}

public static bool SignalAndWait(Original::WaitHandle toSignal, Original::WaitHandle toWaitOn)
@@ -243,7 +243,7 @@
TimeSpan timeout,
bool exitContext)
{
- return SignalAndWait(toSignal, toWaitOn, timeout.Milliseconds, exitContext);
+ return SignalAndWait(toSignal, toWaitOn, (int) timeout.TotalMilliseconds, exitContext);
}
}

Commented Issue: Wrong TimeSpan usage [8715]

etobi — Thu, 22 Sep 2011 16:39:03 GMT

Are you kidding me? *.patch is no recognized file format?

And if I'm posting an issue on chesstool.codeplex.com it's obvious that I'm, referring to the Chess project, isn't it? And all the buggy files were listed in the *.patch file. I'm not going to upload this again, so please take a look here:

http://pastie.org/2574671

Commented Issue: Wrong TimeSpan usage [8715]

mormayo — Thu, 22 Sep 2011 15:58:45 GMT

I have deleted the attachment as it's not a recognized file format. If you have code, then attach a code file or copy-paste code to this issue. There is not much context on this item to do anything with it. What projects or files are you referring to?

Created Issue: Wrong TimeSpan usage [8715]

etobi — Thu, 22 Sep 2011 11:31:54 GMT

Created Issue: Lazy and Volatile causes Execution Timeout Error [8615]

MatthiasFG — Tue, 16 Aug 2011 11:14:36 GMT

Hi there!

I encountered another problem using Alpaca.
I get an Execution Timeout Error with the hint to an "This is a strong indication of a livelock". But to be honest, I've no idea where this might occur.
Any help is highly welcome :-)

Here's my test code:

using System;
using System.Threading.Tasks;
using Microsoft.Concurrency.TestTools.UnitTesting;

namespace MOCTestProject
{
public class AlpacaTest7
{
[DataRaceTestMethod]
public void VolatileTest()
{
var lazy1 = new Lazy<Item3>();

Item3 item1 = null;
Item3 item2 = null;

Parallel.Invoke(
() => { item1 = lazy1.Value; },
() => { item2 = lazy1.Value; }
);

Assert.IsNotNull(item1);
Assert.IsNotNull(item2);
}

public class Item3
{
private volatile bool done;

public Item3()
{
done = Text != "Text";
if (done == false)
Text = "Test";
}

public string Text { get; private set; }
}
}
}

Created Issue: Lazy and nested lock causes Execution Timeout Error [8614]

MatthiasFG — Tue, 16 Aug 2011 08:17:54 GMT

Hi there!

I encountered another problem using Alpaca.
I get an Execution Timeout Error with the hint to an "This is a strong indication of a livelock". But to be honest, I've not idea where this might occur.
Any help is highly welcome :-)

Here's my test code:

using System;
using System.Threading.Tasks;
using Microsoft.Concurrency.TestTools.UnitTesting;

namespace MOCTestProject
{
public class AlpacaTest5
{
[DataRaceTestMethod]
public void LazyTest()
{
var lazy1 = new Lazy<Item>(() => new Item("1"));

Item item1 = null;
Item item2 = null;

Parallel.Invoke(
() => { item1 = lazy1.Value; },
() => { item2 = lazy1.Value; }
);

Assert.IsNotNull(item1);
Assert.IsNotNull(item2);
}

public class Item
{
private readonly object syncObject = new object();

public Item(string text)
{
lock (syncObject)
Text = text;
}

public string Text { get; private set; }
}
}

-Matthias

Commented Issue: Alpaca Test reports Data Race when using Lambdas [8081]

MatthiasFG — Mon, 15 Aug 2011 09:22:43 GMT

Hi!

running the given sample from below I get a Data Race reported for the "LambdaCausesDataRace" test and no Data Race for the "ForeachLoopCausesNoDataRace" test. Why?

using System.Collections.Generic;
using System.Linq;
using System.Threading.Tasks;
using Microsoft.Concurrency.TestTools.UnitTesting;

namespace MOCTestProject
{
public class AlpacaTest2
{

[DataRaceTestMethod]
public void ForeachLoopCausesNoDataRace()
{
var parameters = new[] { new object(), "test", 5 };
string result1 = null;
string result2 = null;

Parallel.Invoke(
() =>
{
result1 = ParametersToTypeListUsingForeachLoop(parameters);
},

() =>
{
result2 = ParametersToTypeListUsingForeachLoop(parameters);
}
);

Assert.AreEqual("Object, String, Int32", result1);
Assert.AreEqual("Object, String, Int32", result2);
}

private static string ParametersToTypeListUsingForeachLoop(object[] parameters)
{
List<string> result = new List<string>();
foreach (var p in parameters)
{
result.Add(p == null ? null : p.GetType().Name);
}
return string.Join(", ", result);
}

[DataRaceTestMethod]
public void LambdaCausesDataRace()
{
var parameters = new[] { new object(), "test", 5 };
string result1 = null;
string result2 = null;

Parallel.Invoke(
() =>
{
result1 = ParametersToTypeListUsingLambda(parameters);
},

() =>
{
result2 = ParametersToTypeListUsingLambda(parameters);
}
);

Assert.AreEqual("Object, String, Int32", result1);
Assert.AreEqual("Object, String, Int32", result2);
}

private static string ParametersToTypeListUsingLambda(object[] parameters)
{
return string.Join(", ", parameters.Select(p => p == null ? null : p.GetType().Name).ToArray());
}
}
}

-Matthias
Comments: ** Comment from web user: MatthiasFG **

Looks like it's an extension method issues.
Can Alpaca/mchess handle extension methods?

Commented Issue: Alpaca Test reports Data Race when using Lambdas [8081]

MatthiasFG — Mon, 15 Aug 2011 09:18:27 GMT

looks like its an extension methos issue.
Can Alpaca/mchess handle extension methods?

Closed Issue: Exception when repro'ing a test in debugger w/breakpoints set before/after preemptions [8483]

mormayo — Fri, 15 Jul 2011 05:44:45 GMT

This was reported by tball:

alpaca\ChessTesting\ConcurrencyTools\RegressionTesting\MCUT.Framework\ConflictSerializabilityTestMethodTests.cs

1. comment out the ExpectedResult as below
[ConflictSerializabilityTestMethod]
//[ExpectedResult(TestResultType.Error)] // TODO make special error type for these?
public void Test1()
...
2. Run Test1() in alpaca to get an error.
3. Then try to “Repro in Debugger”, selecting “break before/after preemptions”.

Result:
mcut.exe!Microsoft.Concurrency.TestTools.UnitTesting.MCutConsole.TestCaseRunnerEngine.PreProcessResults(Microsoft.Concurrency.TestTools.Execution.TestResultEntity testResult) Line 131 + 0x1c bytes C#
mcut.exe!Microsoft.Concurrency.TestTools.UnitTesting.MCutConsole.Program.RunTestCaseGetResult(string testCaseFilePath) Line 335 + 0xe bytes C#
mcut.exe!Microsoft.Concurrency.TestTools.UnitTesting.MCutConsole.Program.RunTestCase(string testCaseFilePath) Line 289 + 0x9 bytes C#
mcut.exe!Microsoft.Concurrency.TestTools.UnitTesting.MCutConsole.Program.Main(string[] args) Line 209 + 0xc bytes C#

internal TestResultEntity PreProcessResults(TestResultEntity testResult)
{
return runner.PreProcessResults(metadata, testResult); <<<< null ref on 'runner'
}
Comments: Resolved with changeset 60543.

Created Issue: Exception when repro'ing a test in debugger w/breakpoints set before/after preemptions [8483]

mormayo — Fri, 15 Jul 2011 05:32:25 GMT

Commented Feature: Create Ribbon Bar to replace right-click menus [8237]

MatthiasFG — Thu, 02 Jun 2011 09:25:13 GMT

This feature has been discussed by Tom and Joe to improve usability. The new menu bar ribbon will be modeled to look similar to Office 2010's ribbon bar system.
Comments: ** Comment from web user: MatthiasFG **

nice to hear but to be honest, I would like to see my current problems fixed.

-Matthias

Created Issue: Alpaca crashes on static lock object [8320]

MatthiasFG — Thu, 02 Jun 2011 09:23:49 GMT

Hi!

I made a very simple sample (see attached file) which will crash an Alpca Schedule Test Run.
What is "special" about the sample is, that it uses a static class which in turn has a lock on a static sync object.
But I really have no idea why the abnormal test program termination of Alpaca happens.

BTW: I hope that any of me reported errors/problems will get fixed anytime.

-Matthias

Commented Feature: Create Ribbon Bar to replace right-click menus [8237]

mormayo — Wed, 11 May 2011 13:09:19 GMT

This feature has been discussed by Tom and Joe to improve usability. The new menu bar ribbon will be modeled to look similar to Office 2010's ribbon bar system.
Comments: Associated with changeset 58275.

Created Feature: Create Ribbon Bar to replace right-click menus [8237]

mormayo — Wed, 11 May 2011 13:08:33 GMT

This feature has been discussed by Tom and Joe to improve usability. The new menu bar ribbon will be modeled to look similar to Office 2010's ribbon bar system.

Closed Feature: One-Click to Repro and view in Concurrency Explorer (CE) [7687]

mormayo — Thu, 05 May 2011 03:15:08 GMT

We want a easier way for students to get the CE open.
Furthermore, it's confusing that you can right-click on a task to do a repro but the CE doesn't open correctly. Just elimitate it and only enable it to be done from the Chess Result UI node.
Comments: Resolved with changeset 58063.

Commented Issue: Alpaca Test reports Data Race but don't know why [8077]

MatthiasFG — Wed, 04 May 2011 21:10:09 GMT

I wrote some Alpaca Tests and really like the tool and it helped me a lot in finding bad code.
But with the following lines of code I get a Data Race error but don't know why. Can you please be so kind and give me some insights why this is the case?
BTW: I'm using build 61646 from http://ppcp.codeplex.com

using System.Collections.Concurrent;
using System.Threading.Tasks;
using Microsoft.Concurrency.TestTools.UnitTesting;

namespace MOCTestProject
{
public class AlpacaTest
{
[DataRaceTestMethod]
public void AddAndRemove()
{
ConcurrentDictionary<string, MyData> ccd = new ConcurrentDictionary<string, MyData>();

Parallel.Invoke(
() => ccd.TryAdd("k1", new MyData()),

() =>
{
MyData data;
if (ccd.TryRemove("k1", out data))
{
data.Cleanup();
}
}
);
}
}

public class MyData
{
private string data;

public MyData()
{
data = "value";
}

public void Cleanup()
{
data = null;
}
}
}
Comments: ** Comment from web user: MatthiasFG **

I was just wondering why there was the "Associated with changeset 58005" statement.

-Matthias

Commented Issue: Alpaca Test reports Data Race but don't know why [8077]

mormayo — Wed, 04 May 2011 19:02:51 GMT

I only checked in the code that reproduces the issues. Nothing has been fixed by them.

Commented Issue: Alpaca Test reports Data Race but don't know why [8077]

MatthiasFG — Wed, 04 May 2011 14:09:00 GMT

Hi Joe!

I downloaded 58009 and build Alpaca and all the other projects and run it on my sample code.
But I still get the DataRace reports.
Did I made something wrong?

-Matthias

Commented Issue: Alpaca Test reports Data Race when using Lambdas [8081]

MatthiasFG — Wed, 04 May 2011 14:07:57 GMT

Hi Joe!

I downloaded 58009 and build Alpaca and all the other projects and run it on my sample code.
But I still get the DataRace reports.
Did I made something wrong?

-Matthias